Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Address outdated references to AWSx #3650

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Address outdated references to AWSx #3650

merged 5 commits into from
Nov 29, 2023

Conversation

cnunciato
Copy link
Contributor

@cnunciato cnunciato commented Nov 18, 2023 •
edited
Loading

Fixes pulumi/docs#11566
Part of pulumi/docs#10230.

Also adds:

  • A new shortcode, example-program-snippet, for rendering a code block (or a portion of one) from a source file
  • Another shortcode, example-program, for rendering a set of related examples in all languages
  • Pulumi programs for many of the examples we show in the AWSx guides (including Javascript)
  • A script for testing all of these programs so we can be sure any snippets we write also work! ✨

@cnunciato cnunciato changed the title cnunciato/awsx docs Address outdated references to AWSx Nov 18, 2023
@pulumi-bot
Copy link
Collaborator

Your site preview for commit ee20305 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-ee203052.s3-website.us-west-2.amazonaws.com.

desteves
desteves approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@desteves desteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f1cd602 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-f1cd602f.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit e79be6d is ready! 🎉

http://pulumi-hugo-origin-pr-3650-e79be6d1.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit cffcc6d is ready! 🎉

http://pulumi-hugo-origin-pr-3650-cffcc6d8.s3-website.us-west-2.amazonaws.com.

@interurban interurban mentioned this pull request Nov 22, 2023
Closed
@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 2 times, most recently from 7d0ab07 to 95ffec1 Compare November 22, 2023 20:24
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 95ffec1 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-95ffec1c.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 58f1478 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-58f14782.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 2 times, most recently from 62bfa30 to 9558f80 Compare November 23, 2023 00:36
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 62bfa30 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-62bfa305.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 9558f80 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-9558f80e.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 449834f is ready! 🎉

http://pulumi-hugo-origin-pr-3650-449834fe.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit ca0e26f is ready! 🎉

http://pulumi-hugo-origin-pr-3650-ca0e26f4.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 2 times, most recently from 61126b1 to e551e43 Compare November 23, 2023 01:04
@pulumi-bot
Copy link
Collaborator

Your site preview for commit d238fea is ready! 🎉

http://pulumi-hugo-origin-pr-3650-d238fea4.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 4c3c04a is ready! 🎉

http://pulumi-hugo-origin-pr-3650-4c3c04a5.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit f6dbc33 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-f6dbc33d.s3-website.us-west-2.amazonaws.com.

@toriancrane
Copy link
Contributor

Hey hey,

Regarding the snippet shortcode, I created a similar shortcode called loadcode that I've been using in the new tutorials to inject code snippets from files. Should we look into consolidating these?

@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 3 times, most recently from dba28ff to ce48c04 Compare November 29, 2023 01:32
@pulumi-bot
Copy link
Collaborator

Your site preview for commit ce48c04 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-ce48c041.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 2 times, most recently from 0eee147 to 2278a62 Compare November 29, 2023 01:42
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 0eee147 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-0eee147e.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 2278a62 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-2278a621.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 21b825e is ready! 🎉

http://pulumi-hugo-origin-pr-3650-21b825e3.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit a68ee84 is ready! 🎉

http://pulumi-hugo-origin-pr-3650-a68ee84f.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato force-pushed the cnunciato/awsx-docs branch 2 times, most recently from 0619f7c to 331ecca Compare November 29, 2023 02:09
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 331ecca is ready! 🎉

http://pulumi-hugo-origin-pr-3650-331eccac.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3d40c4e is ready! 🎉

http://pulumi-hugo-origin-pr-3650-3d40c4e9.s3-website.us-west-2.amazonaws.com.

@cnunciato cnunciato merged commit 237f43a into master Nov 29, 2023
2 checks passed
@cnunciato cnunciato deleted the cnunciato/awsx-docs branch November 29, 2023 02:22
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 0619f7c is ready! 🎉

http://pulumi-hugo-origin-pr-3650-0619f7c6.s3-website.us-west-2.amazonaws.com.

cnunciato added a commit that referenced this pull request Nov 29, 2023
@cnunciato
Revert #3650 (#3673)
93be35f 
* Revert "Update the AWS Guides index page"

This reverts commit ee20305.

* Revert "Rename to programs, clean a few things up"

This reverts commit 3d40c4e.

* Revert "Add ECS page examples"

This reverts commit 245c66e.

* Revert "Update aws/guides/ecr"

This reverts commit cffcc6d.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@desteves desteves desteves approved these changes

@scottslowe scottslowe scottslowe approved these changes

@interurban interurban Awaiting requested review from interurban interurban is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python examples throw error: "missing 1 required keyword-only argument: 'name'"
5 participants
@cnunciato @pulumi-bot @toriancrane @scottslowe @desteves